NetCommonsFormヘルパの構造がFormHelper継承なのに実装がラッパーになってたので、ラッパー側にあわせてみた#46
Merged
s-nakajima merged 1 commit intomasterfrom Sep 24, 2015
Merged
NetCommonsFormヘルパの構造がFormHelper継承なのに実装がラッパーになってたので、ラッパー側にあわせてみた#46s-nakajima merged 1 commit intomasterfrom
s-nakajima merged 1 commit intomasterfrom
Conversation
s-nakajima
added a commit
that referenced
this pull request
Sep 24, 2015
…elper NetCommonsFormヘルパの構造がFormHelper継承なのに実装がラッパーになってたので、ラッパー側にあわせてみた
Member
|
PHPMDのエラーは、phpmd2.3.xになったことによるエラー。@s-nakajimaが後程対応する。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
おそらくFormヘルパとNetCommonsFormヘルパ混在で使ってもセキュリティコンポーネントが動くようにラップパターンで実装したのだと思われるがFormヘルパを継承してるのでFormヘルパにあるメソッドを呼び出すとそこだけラップにならなくなってた。
Formヘルパ継承をやめて自前拡張してないメソッドはFormヘルパへ丸投げするラッパーにした。
Formヘルパ、NetCommonsFormヘルパ混在でもNetCommonsFormヘルパでcreateからendまで書いてもセキュリティコンポーネントとちゃんと連動します。